RFR: 8301996: Move field resolution information out of the cpCache [v8]

[Martin Doerr]

On Wed, 12 Jul 2023 15:08:41 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> 8301996: Move field resolution information out of the cpCache
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   RISCV port

src/hotspot/cpu/x86/templateTable_x86.cpp line 2746:

> 2744: 
> 2745:   // Store TOS into index register in case it is needed later
> 2746:   __ load_unsigned_byte(index, Address(cache, in_bytes(ResolvedFieldEntry::type_offset())));

I can't see where "index" is used as index. I'd call it e.g. "tos_state" (it's not the actual top of stack, it's the state of it, see comments above `enum TosState`). Please don't confuse these terms. That makes the code hardly readable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14129#discussion_r1270515919