RFR: 8312502: Mass migrate HotSpot attributes to the correct location [v2]

[Julian Waters]

On Sun, 23 Jul 2023 11:32:55 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 40 additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into patch-6
>>  - arguments.hpp
>>  - arguments.hpp
>>  - globalDefinitions_gcc.hpp
>>  - assembler_aarch64.hpp
>>  - macroAssembler_aarch64.cpp
>>  - vmError.cpp
>>  - vmError.cpp
>>  - macroAssembler_aarch64.cpp
>>  - assembler_aarch64.hpp
>>  - ... and 30 more: https://git.openjdk.org/jdk/compare/67e2bb59...afff56f2
>
> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 38:
> 
>> 36: #ifdef __GNUC__
>> 37: 
>> 38: // ISO C++ asm is always implicitly volatile
> 
> I can find no evidence for this claim, and it seems to me likely incorrect.  This is also way outside the
> described scope of this PR.

Hi Kim, it's actually listed under https://gcc.gnu.org/onlinedocs/gcc/Basic-Asm.html as follows:

> Qualifiers
volatile
The optional volatile qualifier has no effect. All basic asm blocks are implicitly volatile.

I'll take this outside of this PR though

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14969#discussion_r1271440784