RFR: 8312121: Fix -Wconversion warnings in tribool.hpp
Coleen Phillimore
coleenp at openjdk.org
Mon Jul 24 12:14:41 UTC 2023
On Mon, 17 Jul 2023 18:46:13 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Or cast the `2` to `(u1)2` ?
>
> It does seem strange that this code is using a bit-field, but still using & | and shift. Why not represent the high and low bit with two separate bit-fields of width 1?
I tried to change the class to be int value : 1, init: 1; the changes got a bit ugly when fixing the TriBoolArray functions.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14892#discussion_r1272179086
More information about the hotspot-dev
mailing list