RFR: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic [v3]

[Vladimir Kempik]

On Mon, 24 Jul 2023 12:09:07 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> I have done it in a slightly different way, still removing all "mv"s you have mentioned
>
> Ah, I see you used `t0` instead. I once considered that, but I would still suggest `x7` which would be safer. `t0` as a scratch register are implicitly clobbered/used by so many assembler functions that it's risky to keep a live value in it across assemblers like `inflate_lo32`. `x7` should be a better candidate here as it is only updated at label `CALCULATE_DIFFERENCE` in function generate_compare_long_string_different_encoding.

Good points

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14534#discussion_r1272214995