RFR: 8308903: Print detailed info for Java objects in -Xlog:cds+map [v5]

[Calvin Cheung]

On Mon, 24 Jul 2023 16:17:30 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/cds/archiveBuilder.cpp line 1069:
>> 
>>> 1067:         ShouldNotReachHere();
>>> 1068:       }
>>> 1069: 
>> 
>> Blank line added by accident?
>
> I added this blank line to separate the following lines from the previous loop, to make the code easier to read.

Ok

>> src/hotspot/share/cds/archiveHeapWriter.cpp line 546:
>> 
>>> 544: 
>>> 545:   BitMap::idx_t idx = requested_field_addr - (Metadata**) _requested_bottom;
>>> 546:   return (idx < heap_info->ptrmap()->size()) && (heap_info->ptrmap()->at(idx) == true);
>> 
>> For the second condition, would it be clearer to check for non-null?
>>     `heap_info->ptrmap()->at(idx) != nullptr`
>
> `heap_info->ptrmap()->at(idx)` return a `bool` to indicate whether this index is marked or not.

I see.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14841#discussion_r1272484271
PR Review Comment: https://git.openjdk.org/jdk/pull/14841#discussion_r1272485022