RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers [v4]

[Jaikiran Pai]

On Wed, 12 Jul 2023 12:17:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review changes to fix -Wconversion warnings that come from assembler_<cpu>.cpp by adding narrow_casts to the emit_int8,16,24, and 32 functions.  And some other fixups with checked_cast.
>> 
>> Ran tier1 on Oracle platforms, and tier1-4 on linux-x64-debug, linux-aarch64-debug, windows-x64-debug.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix indentation, thanks for pointing that out @aph.

Hello Coleen, looks like the github actions job failure in this PR for windows-aarch64 are genuine - I see it failing in some other recent unrelated PRs containing this commit, like here https://github.com/openjdk/jdk/pull/15012


=== Output from failing command(s) repeated here ===
* For target hotspot_variant-server_libjvm_gtest_objs_BUILD_GTEST_LIBJVM_pch.obj:
BUILD_GTEST_LIBJVM_pch.cpp
d:\a\jdk\jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(657): error C2220: the following warning is treated as an error
d:\a\jdk\jdk\src\hotspot\cpu\aarch64\assembler_aarch64.hpp(657): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
   ... (rest of output omitted)

* All command lines available in /d/a/jdk/jdk/build/windows-aarch64/make-support/failure-logs.
=== End of repeated output ===

No indication of failed target found.
HELP: Try searching the build log for '] Error'.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14822#issuecomment-1649423711