RFR: 8312121: Fix -Wconversion warnings in tribool.hpp [v4]

Dean Long dlong at openjdk.org
Wed Jul 26 04:33:50 UTC 2023


On Tue, 25 Jul 2023 15:16:06 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Assigning _value first, and then doing _value | 2 doesn't get -Wconversion warnings.  Also, reduced include file inclusion a little.
>> Tested with tier1 on linux-x64-debug, windows-x64-debug, macos-aarch64-debug
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add some more u1 casts to keep Windows compiler happy hopefully.

We don't need the & 3 if we do something like:

`_value = newval ? 3 : 2;`

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14892#issuecomment-1650963686


More information about the hotspot-dev mailing list