RFR: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic [v7]

Vladimir Kempik vkempik at openjdk.org
Wed Jul 26 07:45:56 UTC 2023


On Wed, 26 Jul 2023 03:42:58 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Vladimir Kempik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reduce registers usage and nits
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 2396:
> 
>> 2394:       __ bind(LOAD_LAST);   // cnt2 = 1..7 characters left
>> 2395: 
>> 2396:       __ addi(cnt2, cnt2, -wordSize); //cnt2 is now an offset in strL which points to last 8 bytes
> 
> Indentation: // cnt2 is now an offset in strL which points to last 8 bytes

fixed, now pending positive tier1/tier2 results after all recent changes

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14534#discussion_r1274508298


More information about the hotspot-dev mailing list