RFR: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers [v4]

Jaikiran Pai jpai at openjdk.org
Wed Jul 26 07:53:03 UTC 2023


On Wed, 12 Jul 2023 12:17:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review changes to fix -Wconversion warnings that come from assembler_<cpu>.cpp by adding narrow_casts to the emit_int8,16,24, and 32 functions.  And some other fixups with checked_cast.
>> 
>> Ran tier1 on Oracle platforms, and tier1-4 on linux-x64-debug, linux-aarch64-debug, windows-x64-debug.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix indentation, thanks for pointing that out @aph.

Hello Coleen, I didn't have access to this platform other than Github actions. I see that you fixed this issue in https://bugs.openjdk.org/browse/JDK-8312979, so thank you for that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14822#issuecomment-1651164444


More information about the hotspot-dev mailing list