RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v2]

[Matias Saavedra Silva]

On Wed, 26 Jul 2023 18:52:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge fix
>>  - Restores java loaders
>>  - Ioi and David comments
>>  - Windows fix
>>  - 8306582: Remove MetaspaceShared::exit_after_static_dump()
>
> src/java.base/share/native/libjli/java.c line 464:
> 
>> 462:     if (dumpSharedSpaces) {
>> 463:       CHECK_EXCEPTION_LEAVE(0);
>> 464:       LEAVE();
> 
> What is exit status ($?) when -Xshare:dump fails. It looks like any pending exception will be printed and it will exit with 0 but maybe I've missed something.
> 
> In passing, the java launcher uses 4-space indent rather than 2.

I am not incredibly familiar with the java launcher but I believe what I have is a mistake. I will change it to `CHECK_EXCEPTION_LEAVE(1)` instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14879#discussion_r1275516774