RFR: 8312262: Klass::array_klass() should return ArrayKlass pointer
Coleen Phillimore
coleenp at openjdk.org
Thu Jul 27 21:48:51 UTC 2023
On Thu, 27 Jul 2023 20:57:56 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> src/hotspot/share/oops/arrayKlass.hpp line 62:
>>
>>> 60: ObjArrayKlass* higher_dimension() const { return _higher_dimension; }
>>> 61: inline ObjArrayKlass* higher_dimension_acquire() const; // load with acquire semantics
>>> 62: void set_higher_dimension(ObjArrayKlass* k) { _higher_dimension = k; }
>>
>> The set_higher_dimension() function seems to be unused. Should we remove it?
>
> I'm using the function in the following PR https://github.com/openjdk/jdk/pull/14959.
Should you be using release_set_higher_dimension in your change @calvinccheung ? It does seem better to not have unsafe alternatives.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15059#discussion_r1276850667
More information about the hotspot-dev
mailing list