RFR: 8312262: Klass::array_klass() should return ArrayKlass pointer [v2]

[Coleen Phillimore]

On Thu, 27 Jul 2023 22:41:00 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is a simple change to make array_klass() return ArrayKlass (the first dimension of TypeArrayKlass is a TypeArrayKlass so can't use ObjArrayKlass), higher_dimension is always an ObjArrayKlass and lower_dimension can be a TypeArrayKlass.  The change removes some casts.
>> Tested with tier1 linux/macosx/windows on x86 and aarch64.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Calvin's suggestions and remove set_higher_dimension.

Thanks for reviewing Calvin. I've rerun the SA tests with your SA suggested changes.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15059#pullrequestreview-1550943773