RFR: 8312121: Fix -Wconversion warnings in tribool.hpp [v5]

Coleen Phillimore coleenp at openjdk.org
Thu Jul 27 22:50:16 UTC 2023


On Thu, 27 Jul 2023 22:26:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Back to V1.
>
> src/hotspot/share/utilities/tribool.hpp line 44:
> 
>> 42:   TriBool() : _value(0) {}
>> 43:   TriBool(bool value) : _value(value) {
>> 44:     _value = _value | 2; // set to not-default
> 
> Why not `|=` here?

I was trying different versions to see if |= would give a warning.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14892#discussion_r1276891643


More information about the hotspot-dev mailing list