RFR: 8312262: Klass::array_klass() should return ArrayKlass pointer [v2]

David Holmes dholmes at openjdk.org
Thu Jul 27 23:24:51 UTC 2023


On Thu, 27 Jul 2023 22:39:10 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> That would be good.  Not this change, but the higher and lower dimensions have to change to not be set inside a Mutex so it'll be safer to only have the acquire/release versions.
>
> Thank you for noticing the set_higher_dimension function is unused, Dean.

But Calvin wants it and doesn't need the release version. Using release where not needed just causes confusion because it screams out "something lock-free and concurrent is happening here", which is not the case in Calvin's code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15059#discussion_r1276921700


More information about the hotspot-dev mailing list