RFR: 8312262: Klass::array_klass() should return ArrayKlass pointer [v3]

Coleen Phillimore coleenp at openjdk.org
Fri Jul 28 12:08:20 UTC 2023


On Thu, 27 Jul 2023 23:21:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thank you for noticing the set_higher_dimension function is unused, Dean.
>
> But Calvin wants it and doesn't need the release version. Using release where not needed just causes confusion because it screams out "something lock-free and concurrent is happening here", which is not the case in Calvin's code.

I can add it back and we can examine it when we fix JDK-8308745.  Maybe add an assert or something that the vm is single threaded.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15059#discussion_r1277459290


More information about the hotspot-dev mailing list