RFR: 8308984: Relativize last_sp (and top_frame_sp) in interpreter frames

Fredrik Bredberg fbredberg at openjdk.org
Fri Jul 28 12:30:15 UTC 2023


Implementation of relativized last_sp (top_frame_sp on PowerPC) in interpreter frames for x64, aarch64, ppc64le and riscv.
Not relativized last_sp on arm, zero and s390 but done some changes to cope with the changed generic code.

By changing the "last_sp" member in interpreter frames from being an absolute address into an offset that is relative to the frame pointer, we don't need to change the value as we freeze and thaw frames of virtual threads. This is since we might freeze and thaw from and to different worker threads, so the absolute address to locals might change, but the offset from the frame pointer will be constant.

This subtask only handles "last_sp" (and its close equivalent "top_frame_sp" on PowerPC). The relativization of other interpreter frame members are handled in other subtasks to JDK-8289296.

Tested tier1-tier7 on supported platforms. The rest was sanity tested using Qemu.

-------------

Commit messages:
 - Fixed an assert failure on linux-x86
 - 8308984: Relativize last_sp in interpreter frames

Changes: https://git.openjdk.org/jdk/pull/14545/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14545&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8308984
  Stats: 148 lines in 28 files changed: 103 ins; 1 del; 44 mod
  Patch: https://git.openjdk.org/jdk/pull/14545.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14545/head:pull/14545

PR: https://git.openjdk.org/jdk/pull/14545


More information about the hotspot-dev mailing list