RFR: 8313202: MutexLocker should disallow null Mutexes [v2]
Aleksey Shipilev
shade at openjdk.org
Fri Jul 28 18:57:15 UTC 2023
> As seen in [JDK-8313081](https://bugs.openjdk.org/browse/JDK-8313081), it is fairly easy to pass nullptr `Mutex` to `MutexLocker` by accident, which would just silently avoid the lock.
>
> There are a few places in Hotspot where we pass `nullptr` to simulate re-entrancy and/or conditionally take the lock. Those places can be more explicit, and the default `MutexLocker` can disallow nullptrs for extra safety.
>
> Open for some bikeshedding on the names of the new `MutexLockers`. Particularly `ReentrantMutexLocker` might lull readers into believing it does safepoint checks on re-entrant "lock", which it actually does not do.
>
> More thorough testing with different GC/JIT combinations is running now, we might find more issues there. Meanwhile, please comment on the approach.
>
> Additional testing:
> - [x] `grep -R "MutexLocker " src/hotspot | grep -i null`, no hits
> - [x] `grep -R "MutexLocker " src/hotspot | grep -i ?`, no hits
> - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` (re-run in progress)
Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
Replace ReentrantMutexLocker with ConditionalMutexLocker
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15043/files
- new: https://git.openjdk.org/jdk/pull/15043/files/5962871f..4b140819
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15043&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15043&range=00-01
Stats: 37 lines in 10 files changed: 6 ins; 11 del; 20 mod
Patch: https://git.openjdk.org/jdk/pull/15043.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15043/head:pull/15043
PR: https://git.openjdk.org/jdk/pull/15043
More information about the hotspot-dev
mailing list