Formatting on Windows

[David Holmes]

Hi Julian,

On 29/07/2023 3:06 pm, Julian Waters wrote:
> As discussed in https://github.com/openjdk/jdk/pull/15063 
> <https://github.com/openjdk/jdk/pull/15063>, how many of these are 
> formatting errors worth fixing, and how should they be fixed if they 
> have to be? gcc has flagged all of them as formatting errors, and while 
> I could simply silence the checker in compilerWarnings_gcc.hpp on 
> Windows, I'm unsure if that's the right course of action to take

Where was it determined that building for Windows using gcc was a goal 
of OpenJDK? This is (as Thomas tried to point out) effectively another 
port, so who is testing and supporting it? I can understand it is an 
interesting side project for you, but we all end up with the burden of 
having to deal with this - first by reviewing these PR's and then by 
dealing with future breakage. AFAIK no one delivering OpenJDK is using 
gcc for a Windows build. You can't expect everyone to check whether a 
change that is fine with VS on Windows is also fine with gcc, so this 
will be forever breaking with ensuing PRs (that others have to expend 
effort reviewing) to fix it again.

Sorry to dampen your enthusiasm on contributing here but there has to be 
a strong reason to make these kinds of changes. Who wants/needs this?

Regards,
David

> best regards,
> Julian