Integrated: 8307312: Replace "int which" with "int cp_index" in constantPool
Matias Saavedra Silva
matsaave at openjdk.org
Mon Jul 31 20:27:04 UTC 2023
On Tue, 25 Jul 2023 20:20:33 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:
> Many accessors in the constant pool take an argument "int which" that is meant to represent an ambiguous index. Despite this, several methods in the API use "int which" when the argument is exclusively a constant pool index. This patch aims to rename all of these instances to "int cp_index" in order to be more clear and to distinguish methods that take constant pool indices and methods that use derived indices.
>
> The callers have been updated to use more clear naming as well. Verified with tier 1-5 tests.
This pull request has now been integrated.
Changeset: c91a3002
Author: Matias Saavedra Silva <matsaave at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c91a3002fb4304b6184d1d8d5611873c4e028af2
Stats: 329 lines in 8 files changed: 0 ins; 0 del; 329 mod
8307312: Replace "int which" with "int cp_index" in constantPool
Reviewed-by: coleenp, dholmes, iklam
-------------
PR: https://git.openjdk.org/jdk/pull/15027
More information about the hotspot-dev
mailing list