RFR: 8305959: x86: Improve itable_stub [v2]

Aleksey Shipilev shade at openjdk.org
Fri Jun 2 18:44:10 UTC 2023


On Thu, 1 Jun 2023 11:47:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Boris Ulasevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains three new commits since the last revision:
>> 
>>  - readability rework
>>  - cleanup
>>  - 8305959: x86: Improve itable_stub
>
> src/hotspot/cpu/x86/vtableStubs_x86_32.cpp line 203:
> 
>> 201: 
>> 202:   start_pc = __ pc();
>> 203:   __ push(temp_reg);
> 
> Why do we need to save this one? Do we care if this "tmp" is clobbered?

This one is still not addressed, in case you missed it, @bulasevich.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13460#discussion_r1214695501


More information about the hotspot-dev mailing list