RFR: 8308966 Add intrinsic for float/double modulo for x86 AVX2 and AVX512 [v4]

Scott Gibbons sgibbons at openjdk.org
Fri Jun 2 19:28:00 UTC 2023


On Fri, 2 Jun 2023 18:39:59 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubGenerator_x86_64_fmod.cpp line 430:
>> 
>>> 428:   __ jcc(Assembler::aboveEqual, L_112a);
>>> 429: //     res = y + y;
>>> 430:   __ vaddsd(xmm0, xmm0, xmm1);
>> 
>> Should this be: __ vaddsd(xmm0, xmm1, xmm1);
>
> This is correct as written according to the disassembly.

After further investigation, you are correct.  Changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14224#discussion_r1214738035


More information about the hotspot-dev mailing list