RFR: 8308966 Add intrinsic for float/double modulo for x86 AVX2 and AVX512 [v6]

Scott Gibbons sgibbons at openjdk.org
Sun Jun 4 17:34:11 UTC 2023


On Sun, 4 Jun 2023 11:56:48 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Indentation; spread source into assembly
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_fmod.cpp line 121:
> 
>> 119:     //     // |x|, |y|
>> 120:     //     a = DP_AND(x, DP_CONST(7fffffffffffffff));
>> 121:     __ movq(xmm0, xmm0);
> 
> Redundatn move.

I do not believe these are redundant, as the upper quadword of the register is cleared as a side-effect of the vmovq.  I do not believe the icx compiler would insert random redundant vmovq instructions at this optimization level.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14224#discussion_r1216942237


More information about the hotspot-dev mailing list