RFR: 8305959: x86: Improve itable_stub [v2]

Andrew Haley aph at openjdk.org
Mon Jun 5 09:35:08 UTC 2023


On Mon, 5 Jun 2023 09:22:11 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

>> This one is still not addressed, in case you missed it, @bulasevich.
>
> Right. Thanks.
> On x86_32 we have register pressure. I have to push-pop rdx to avoid crash. The question must be caused by temp_reg name, which is similar to rscatch. On x86_32 we do not have any scratch register.
> Will it be better if I replace push/pop(temp_reg) with explicit push/pop(rdx)?

On x86_32 we do not have any scratch register. Will it be better if I replace push/pop(temp_reg) with explicit push/pop(rdx)?

Yes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13460#discussion_r1217799527


More information about the hotspot-dev mailing list