RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v14]

[Cesar Soares Lucas]

On Mon, 5 Jun 2023 05:05:26 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Catching up with master branch.
>>    
>>    Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Address PR review 6: refactoring around rematerialization & improve test cases.
>>  - Address PR review 5: refactor on rematerialization & add tests.
>>  - Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Address part of PR review 4 & fix a bug setting only_candidate
>>  - Catching up with master
>>    
>>    Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Fix tests. Remember previous reducible Phis.
>>  - Address PR review 3. Some comments and be able to abort compilation.
>>  - Merge with Master
>>  - Addressing PR review 2: refactor & reuse MacroExpand::scalar_replacement method.
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/46c4da7f...8f81a7c8
>
> src/hotspot/share/code/debugInfo.cpp line 251:
> 
>> 249:     // Set it to true so that the object will get rematerialized
>> 250:     if (!_selected->is_root()) {
>> 251:       _selected->set_root(true);
> 
> Why do you need `_selected` to be marked as root?

I think you're right, there is no need for that. I'll remove/refactor that and run tests again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1218672363