RFR: 8309065: Move the logic to determine archive heap location from CDS to G1 GC [v3]
Thomas Schatzl
tschatzl at openjdk.org
Tue Jun 6 12:48:55 UTC 2023
On Fri, 2 Jun 2023 19:46:31 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:
>> This patch is the first step towards having a single set of GC APIs for allocating heap space for the archived objects (See https://bugs.openjdk.org/browse/JDK-8296263).
>> It moves some of the G1 specific logic from CDS to G1 gc without changing the functionality.
>>
>> Changes that add/update GC APIs for handling archive heap would be introduced in upcoming patches.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments - updates to alloc_archive_regions() api
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
(I can't just request changes without a comment, although I commented before, so here the same again)
Given soon JDK21 fork, and the risk of having this API change for a long time in JDK 21, I am not good with leaving the change as is. Please either fix up the naming or leave integration until after the fork.
-------------
Changes requested by tschatzl (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14208#pullrequestreview-1465116293
More information about the hotspot-dev
mailing list