RFR: 8295976: GetThreadListStackTraces returns wrong state for blocked VirtualThread [v3]

[Serguei Spitsyn]

On Tue, 6 Jun 2023 21:07:46 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fixed typo in a comment in jvmtiEnvBase.cpp
>>  - nit: restored one comment as was before
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadListStackTracesTest/ThreadListStackTracesTest.java line 63:
> 
>> 61:     public void run() {
>> 62:         log("TestTask.run()");
>> 63:     }
> 
> I think this should be an abstract method.

Thanks. Fixed now.

> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadListStackTracesTest/ThreadListStackTracesTest.java line 106:
> 
>> 104:         final Thread.State expState = Thread.State.WAITING;
>> 105:         reentrantLock.lock();
>> 106:         String name = "ObjectMonitorTestTask";
> 
> Should be "ReentrantLockTestTask"

Thanks. Fixed now.

> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadListStackTracesTest/libThreadListStackTracesTest.cpp line 35:
> 
>> 33: extern "C" {
>> 34: 
>> 35: JNIEXPORT jint JNICALL Java_ThreadListStackTracesTest_getStateSingle(JNIEnv* jni, jclass clazz, jthread vthread) {
> 
> I'd suggest splitting into 2 lines just like 
> Java_ThreadListStackTracesTest_getStateMultiple() for the sake of consistency and being able to more easily compare the two.

Thanks. I've overlooked this. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14326#discussion_r1220390676
PR Review Comment: https://git.openjdk.org/jdk/pull/14326#discussion_r1220392423
PR Review Comment: https://git.openjdk.org/jdk/pull/14326#discussion_r1220387806