RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v7]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Jun 6 21:54:14 UTC 2023


On Tue, 6 Jun 2023 21:43:36 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> test/hotspot/jtreg/gc/shenandoah/TestEvilSyncBug.java line 33:
>> 
>>> 31:  * @modules java.base/jdk.internal.misc
>>> 32:  *          java.management
>>> 33:  * @run driver/timeout=480 TestEvilSyncBug -XX:ShenandoahGCHeuristics=aggressive
>> 
>> Probably fine, but why this change to non-generational testing? Will aggressive heuristic sharpen the test?
>
> We moved this argument from the source code (original line 64) to here so that we can invoke the test differently in generational mode.

See line 64 of the original source code.  We did not change the behavior.  We only changed how the behavior is realized.  This enables generalization of the test to generational mode.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1220418431


More information about the hotspot-dev mailing list