RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v3]

Serguei Spitsyn sspitsyn at openjdk.org
Tue Jun 6 22:41:58 UTC 2023


On Tue, 6 Jun 2023 22:17:57 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: removed JVMTI_THREAD_STATE_RUNNABLE from a carrier thread state
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 768:
> 
>> 766:   }
>> 767:   return state;
>> 768: }
> 
> You don't need to call get_thread_state_base in case "passive carrier thread":
> 
>     if (is_passive_carrier_thread(jt, thread_oop)) {
>       return JVMTI_THREAD_STATE_ALIVE | JVMTI_THREAD_STATE_WAITING
>              | JVMTI_THREAD_STATE_WAITING_INDEFINITELY;
>     }
>     return get_thread_state_base(thread_oop, jt);

Thanks. Yes, noticed it. :) Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14298#discussion_r1220484149


More information about the hotspot-dev mailing list