RFR: 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING [v5]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Jun 7 11:31:02 UTC 2023
> When a virtual thread is mounted, the carrier thread should be reported as "waiting" until the virtual thread unmounts. Right now, GetThreadState reports a state based the JavaThread status when it should return JVMTI_THREAD_STATE_WAITING | JVMTI_THREAD_STATE_WAITING_INDEFINITELY.
> The fix adds:
> - a special case for passive carrier threads
> - necessary test coverage to the existing JVMTI test: `serviceability/jvmti/vthread/ThreadStateTest`.
>
> Testing:
> - tested with the updated test: `serviceability/jvmti/vthread/ThreadStateTest`
> - submitted mach5 tiers 1-5
> - TBD: to submit mach5 tier 6
Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
- Merge
- review: call get_thread_state_base only when needed
- review: removed JVMTI_THREAD_STATE_RUNNABLE from a carrier thread state
- Merge
- minor tweaks in libThreadStateTest.cpp
- 8307153: JVMTI GetThreadState on carrier should return STATE_WAITING
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14298/files
- new: https://git.openjdk.org/jdk/pull/14298/files/77771816..3e7618c4
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14298&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14298&range=03-04
Stats: 14603 lines in 141 files changed: 9240 ins; 4758 del; 605 mod
Patch: https://git.openjdk.org/jdk/pull/14298.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14298/head:pull/14298
PR: https://git.openjdk.org/jdk/pull/14298
More information about the hotspot-dev
mailing list