Integrated: 8305959: x86: Improve itable_stub

Boris Ulasevich bulasevich at openjdk.org
Wed Jun 7 11:31:09 UTC 2023


On Thu, 13 Apr 2023 14:33:52 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

> Async profiler shows that applications spend up to 10% in itable_stubs.
> 
> The current inefficiency of itable stubs is as follows. The generated itable_stub scans itable twice: first it checks if the object class is a subtype of the resolved_class, and then it finds the holder_class that implements the method. I suggest doing this in one pass: with a first loop over itable, check pointer equality to both holder_class and resolved_class. Once we have finished searching for resolved_class, continue searching for holder_class in a separate loop if it has not yet been found.
> 
> This approach gives 1-10% improvement on the synthetic benchmarks and 3% improvement on Naive Bayes benchmark from the Renaissance Benchmark Suite (Intel Xeon X5675).

This pull request has now been integrated.

Changeset: 8cdd95e8
Author:    Boris Ulasevich <bulasevich at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8cdd95e8a2a7814ab7983fb3f41e6fa5793d410f
Stats:     295 lines in 5 files changed: 250 ins; 24 del; 21 mod

8305959: x86: Improve itable_stub

Reviewed-by: phh, shade, aph

-------------

PR: https://git.openjdk.org/jdk/pull/13460


More information about the hotspot-dev mailing list