RFR: 8309065: Move the logic to determine archive heap location from CDS to G1 GC [v3]

[Ashutosh Mehra]

On Wed, 7 Jun 2023 09:05:24 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments - updates to alloc_archive_regions() api
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/hotspot/share/cds/filemap.cpp line 2124:
> 
>> 2122: 
>> 2123:   size_t word_size = size / HeapWordSize;
>> 2124:   address requested_start = heap_region_requested_address();
> 
> Possibly for another RFE, if you intent to make this code move as verbatim as possible:
> 
> This feels like something that should use `r->mapping_offset()` directly - would make the code easier to understand.

Not sure I get this. Are you suggesting replacing `heap_region_requested_address` with `r->mapping_offset()`. But they are not the same, right?

> Could we add this limitation to the comment for the casual reader?

Yes, good point. I will update the comment to add this limitation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14208#discussion_r1221704233
PR Review Comment: https://git.openjdk.org/jdk/pull/14208#discussion_r1221705900