RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Jun 7 14:38:29 UTC 2023
On Wed, 7 Jun 2023 07:34:44 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update copyright notices
>
> src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2021, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Should probably be removed.
removed.
> src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2021, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Check if this is necessary.
ok. i'll remove.
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahCompactHeuristics.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Can be removed?
removed.
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahPassiveHeuristics.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Should be removed?
removed.
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahStaticHeuristics.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Should be removed?
removed.
> src/hotspot/share/gc/shenandoah/mode/shenandoahPassiveMode.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2019, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Should be removed?
removed.
> src/hotspot/share/gc/shenandoah/mode/shenandoahSATBMode.cpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2019, 2021, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Can be removed.
removed.
> src/hotspot/share/gc/shenandoah/shenandoahBarrierSetClone.inline.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2013, 2021, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Unnecessary. Delete.
removed.
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.hpp line 3:
>
>> 1: /*
>> 2: * Copyright (c) 2013, 2021, Red Hat, Inc. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
>
> Probably unnecessary.
removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221700458
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221704676
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221706236
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221707142
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221709229
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221710192
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221711143
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221712173
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221713033
More information about the hotspot-dev
mailing list