RFR: 8305104: Remove the old core reflection implementation [v2]

[David Holmes]

On Wed, 7 Jun 2023 22:02:57 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> JEP 416 integrated in JDK 18 and since then, only a couple minor issues has been reported.  Those issues were related with exception being thrown with invalid arguments.   We propose to remove the old core reflection implementation in JDK 22.  The `-Djdk.reflect.useDirectMethodHandle=false` workaround to revert to the old implementation will stop to work.
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix merge issue

Hotspot code and test changes look fine. Thanks.

src/hotspot/share/classfile/verifier.cpp line 298:

> 296:     // NOTE: this is called too early in the bootstrapping process to be
> 297:     // guarded by Universe::is_gte_jdk14x_version().
> 298:     // Also for lambda generated code, gte jdk8

While you are here could you delete these version comments please - they are meaningless these days. Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14371#pullrequestreview-1468854747
PR Review Comment: https://git.openjdk.org/jdk/pull/14371#discussion_r1222355124