RFR: 8309612: [REDO] JDK-8307153 JVMTI GetThreadState on carrier should return STATE_WAITING [v6]
Alex Menkov
amenkov at openjdk.org
Thu Jun 8 18:21:44 UTC 2023
On Thu, 8 Jun 2023 01:42:10 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> This is REDO the fix of [JDK-8307153](https://bugs.openjdk.org/browse/JDK-8307153).
>> The last update of the fix in the review cycle was incorrect and incorrectly tested, so the issue has not been noticed. It is why the fix was backed out.
>> The issue is that the SUSPEND bit was missed in the JVMTI thread state of platform/carrier threads carrying virtual threads (see`JvmtiEnvBase::get_thread_state` function).
>>
>> The first push/patch is the original fix of JDK-8307153.
>> The fix of the SUSPEND bit issue will be in the incremental update.
>> It is to simplify the review.
>>
>> Testing:
>> - TBD: mach5 tiers 1-5
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>
> review: corrected the function get_thread_state for safety
Marked as reviewed by amenkov (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/14366#pullrequestreview-1470533353
More information about the hotspot-dev
mailing list