RFR: 8305104: Remove the old core reflection implementation [v3]

Mandy Chung mchung at openjdk.org
Mon Jun 12 00:53:42 UTC 2023


On Sun, 11 Jun 2023 20:42:49 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review feedback
>
> src/java.base/share/classes/jdk/internal/reflect/MethodHandleAccessorFactory.java line 314:
> 
>> 312:      * 4. the member takes a variable number of arguments and the last parameter
>> 313:      *    is an array (see details below)
>> 314:      * 5. the member's method type has an arity >= 255
> 
> Suggestion:
> 
>      * 1. during VM early startup before method handle support is fully initialized
>      * 2. a Java native method
>      * 3. -Djdk.reflect.useNativeAccessorOnly=true is set
>      * 4. the member takes a variable number of arguments and the last parameter
>      *    is not an array (see details below)
>      * 5. the member's method type has an arity >= 255

Fixed.  Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14371#discussion_r1225976789


More information about the hotspot-dev mailing list