RFR: 8309065: Move the logic to determine archive heap location from CDS to G1 GC [v2]
Ashutosh Mehra
duke at openjdk.org
Mon Jun 12 12:46:50 UTC 2023
On Fri, 2 Jun 2023 18:59:03 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>>> I think Thomas's point is, the requested range should be passed to the alloc_archive_regions() API, even though the collector may simply ignore it.
>>
>> @tschatzl @iklam Other collectors may ignore the requested addr, but G1 can just allocate the regions at the requested addr, right? Do we also need the fallback to allocating at the top of heap if for some reason allocation at requested addr fails?
>
>> > I think Thomas's point is, the requested range should be passed to the alloc_archive_regions() API, even though the collector may simply ignore it.
>>
>> @tschatzl @iklam Other collectors may ignore the requested addr, but G1 can just allocate the regions at the requested addr, right? Do we also need the fallback to allocating at the top of heap if for some reason allocation at requested addr fails?
>
> Yes, I think we need the fallback. However, I think we can keep the behavior exactly the same in this PR (only allocate at the heap end), and implement the more optimal allocation in a subsequent PR.
Thanks @iklam @tschatzl @tstuefe for reviewing the changes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14208#issuecomment-1587269013
More information about the hotspot-dev
mailing list