RFR: 8309685: Fix -Wconversion warnings in assembler and register code [v2]
Coleen Phillimore
coleenp at openjdk.org
Wed Jun 14 00:21:14 UTC 2023
> This change widens some int arguments, narrows some int returns and adds some casts and checked_casts where the compiler was doing the implicit conversion. I maintained existing types - ie if the parameter was short, I used a cast to short. Also int is used in places that might be better served as unsigned int but I didn't fix that because it would be too large and risky. The registers encode an offset in an array, so it's safe to checked_cast<> to get their encoding. This fix is limited so that the types changed and casts added are intentional.
> See CR for counts of -Wconversion warnings this resolves.
> Tested with tier1-7, also tested with tier1 on all Oracle supported platforms.
Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
Improve checked_cast to tolerate sign extension so it can be used in assembler.hpp emit code.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14396/files
- new: https://git.openjdk.org/jdk/pull/14396/files/f084adff..aac605ac
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14396&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14396&range=00-01
Stats: 26 lines in 2 files changed: 12 ins; 2 del; 12 mod
Patch: https://git.openjdk.org/jdk/pull/14396.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14396/head:pull/14396
PR: https://git.openjdk.org/jdk/pull/14396
More information about the hotspot-dev
mailing list