RFR: 8309258: RISC-V: Add riscv_hwprobe syscall [v2]

Robbin Ehn rehn at openjdk.org
Wed Jun 14 08:23:12 UTC 2023


On Wed, 14 Jun 2023 07:16:49 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   free uarch string
>
> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 93:
> 
>> 91: 
>> 92:   RiscvHwprobe::probe_features();
>> 93:   os_aux_features();
> 
> Looks like `probe_features` and `os_aux_features` are doing the same thing (enabling supported extensions). Should we call them both? Maybe it's better to call `os_aux_features` when `probe_features` returns false? e.g.:
> 
> 
> if (!RiscvHwprobe::probe_features()) {
>   os_aux_features();
> }

Yes, ok, sure! (note that V is not yet in hwprobe (but it is in pipeline))

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14445#discussion_r1229207282


More information about the hotspot-dev mailing list