RFR: 8310076: Reduce inclusion of bytecodeStream.hpp

David Holmes dholmes at openjdk.org
Thu Jun 15 03:03:56 UTC 2023


On Thu, 15 Jun 2023 01:17:26 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> The popular header file generateOopMap.hpp includes bytecodeStream.hpp, but it doesn't actually needs the full declaration of the BytecodeStream class.
> 
> This inclusion can be replaced with a simple forward declaration of the BytecodeStream class.
> 
> This reduces the number of HotSpot .o files that include bytecodeStream.hpp from 571 to 21.

Seems fine. Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14481#pullrequestreview-1480584272


More information about the hotspot-dev mailing list