RFR: 8309408: Thread.sleep cleanup
Alan Bateman
alanb at openjdk.org
Thu Jun 15 07:16:59 UTC 2023
On Mon, 5 Jun 2023 19:44:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> > I think we need to delay this until [JDK-8309361](https://bugs.openjdk.org/browse/JDK-8309361) is resolved, in case we would like to revert [JDK-8305092](https://bugs.openjdk.org/browse/JDK-8305092).
>
> Okay, I won't integrate this until we see what the issue is. That said, if the sub-mills support needs to be reverted then I think we should keep the interface as nanos on the boundary between the VM and the libraries. The reason is that it's mostly nanos at the Java level now, meaning 2 out of the 3 sleep methods support sub-mills, and the virtual thread sleep and the JFR event are in nanos too.
JDK-8309361 doesn't have a conclusion yet but doesn't look like it's a JDK implementation issue or heading toward removing the support for sub-mills precision. So I think we should integrate this cleanup and get it out of the way. Even if there are changes then I think it's better for the precision at the interface to be nanos.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14303#issuecomment-1592491455
More information about the hotspot-dev
mailing list