RFR: JDK-8310020: MacroAssembler::call_VM(_leaf) doesn't consistently check for conflict with C calling convention. [v2]

[Damon Fenacci]

On Thu, 15 Jun 2023 07:09:54 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 1628:
> 
>> 1626:   assert_different_registers(arg_0, c_rarg1, c_rarg2, c_rarg3);
>> 1627:   assert_different_registers(arg_1, c_rarg2, c_rarg3);
>> 1628:   assert_different_registers(arg_2, c_rarg2);
> 
> Shouldn't this be
> 
> Suggestion:
> 
>   assert_different_registers(arg_2, c_rarg3);
> 
> ?

Totally! Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14470#discussion_r1230547028