RFR: JDK-8310020: MacroAssembler::call_VM(_leaf) doesn't consistently check for conflict with C calling convention. [v3]
Damon Fenacci
duke at openjdk.org
Thu Jun 15 08:22:17 UTC 2023
> # Issue
> The `MacroAssembler::call_VM` and `MacroAssembler::call_VM_leaf` methods don't include asserts to check if the passed arguments collide with the C calling convention registers **consistently**. Some versions omit them completely (e.g. aarch64 `MacroAssembler::call_VM_leaf`), other ones use regular asserts (where the `assert_different_registers` function should be used).
>
> # Solution
> We use `assert_different_registers` across all `MacroAssembler::call_VM` and `MacroAssembler::call_VM_leaf` where a check is needed (except for the arm implementation, which doesn't change as it uses fixed registers).
>
> # Testing
> This fix includes changes for x86_32/64 and aarch64, which I could test thoroughly but also for **ppc,** **riscv**, and **s390** for which I would **need some help with testing**.
Damon Fenacci has updated the pull request incrementally with one additional commit since the last revision:
JDK-8310020: add missing riscv asserts
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14470/files
- new: https://git.openjdk.org/jdk/pull/14470/files/841f0181..a7a1abd1
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14470&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14470&range=01-02
Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/14470.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14470/head:pull/14470
PR: https://git.openjdk.org/jdk/pull/14470
More information about the hotspot-dev
mailing list