RFR: 8310170: Use sp's argument to improve performance of outputStream::indent

Aleksey Shipilev shade at openjdk.org
Fri Jun 16 13:07:03 UTC 2023


On Thu, 15 Jun 2023 20:50:11 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> Please consider this small enhancement. `sp` takes a count argument, this was never used by `indent`, let's just use it.

Looks okay. I thought what would happen if `_indentation < _position`, but `sp()` seems to handle `count < 0` fine.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14502#pullrequestreview-1483468043


More information about the hotspot-dev mailing list