RFR: JDK-8310107: os::trace_page_sizes_for_requested_size should name alignment as requested page size [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri Jun 16 14:18:29 UTC 2023
On Fri, 16 Jun 2023 07:23:29 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> I think this looks reasonable and we should also change `os::trace_page_sizes` to have the same order when printing `base`, `size`, and `page_size`.
Thank you, @stefank . New version changes printing- and argument order of `os::trace_page_sizes` to equal `os::trace_page_sizes_for_requested_size()`.
While checking the affected tests, I noticed that gc/g1/TestLargePageUseForAuxMemory.java is broken when running on machines with 1G pages configured. Opened a separate issue https://bugs.openjdk.org/browse/JDK-8310216 to track that.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14484#issuecomment-1594756059
More information about the hotspot-dev
mailing list