RFR: 8310110: Shenandoah: Trace page sizes

[Thomas Stuefe]

On Fri, 16 Jun 2023 09:36:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> The idea looks good.
> 
> I would prefer not to have a one-liner helper method, and instead inline the uses like this:
> 
> ```
>    if (ShenandoahVerify) {
>      ReservedSpace verify_bitmap(_bitmap_size, bitmap_page_size);
> +    os::trace_page_sizes_for_requested_size("Verify Bitmap", bitmap_size_orig,
> +                                            bitmap.page_size(), bitmap_page_size,
> +                                            bitmap.base(), bitmap.size());
>      if (!verify_bitmap.special()) {
> ```

Okay.

> 
> Also, let's wait for #14484 to land first?

Certainly. Mind reviewing #14484 ? It's very simple.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14486#issuecomment-1594762872