RFR: 8310110: Shenandoah: Trace page sizes [v2]

[Aleksey Shipilev]

On Mon, 19 Jun 2023 07:11:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> `-Xlog:pagesize` now produced this printout
>> 
>> 
>> [0.006s][info][pagesize] Heap: req_size=5G base=0x00000006c0000000 page_size=1G alignment=1G size=5G
>> [0.006s][info][pagesize] Mark Bitmap: req_size=160M base=0x00007fc4c0000000 page_size=1G alignment=1G size=1G
>> [0.011s][info][pagesize] Aux Bitmap: req_size=160M base=0x00007fc4c0000000 page_size=1G alignment=1G size=1G
>> [0.011s][info][pagesize] Region Storage: req_size=320K base=0x00007fc3c0000000 page_size=1G alignment=1G size=1G
>> [0.011s][info][pagesize] Collection Set: req_size=16K base=0x0000000000010000 page_size=4K alignment=4K size=16K
>> 
>> 
>> Note that this printout is from a machine with 1G pages and -XX:+UseLargePages; it nicely demonstrates how much memory we waste in that case on support structures; https://bugs.openjdk.org/browse/JDK-8310111 tracks that.
>> 
>> Also note that I reuse `os::trace_page_sizes_for_requested_size` here, which I think can be improved and made clearer (alignment is actually requested pagesize). This is tracked separately in https://github.com/openjdk/jdk/pull/14484 .
>
> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - enable runtime/os/TestTracePageSizes.java for shenandoah
>  - feedback aleksey
>  - Merge branch 'master' into JDK-8310110-Trace-page-sizes
>  - JDK-8310110-Trace-page-sizes

Looks okay to me!

I would prefer the style to be:


  os::trace_page_sizes_for_requested_size("Mark Bitmap",
                                          bitmap_size_orig, bitmap_page_size,
                                          bitmap.base(),
                                          bitmap.size(), bitmap.page_size());


...so that we have:


line 1: label
line 2: original size, page size
line 3: base addr
line 4: actual size, page size


Would be easier to check lines 2 and 4 match?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14486#pullrequestreview-1485642102