RFR: JDK-8287061: Support for rematerializing scalar replaced objects participating in allocation merges [v18]

Cesar Soares Lucas cslucas at openjdk.org
Mon Jun 19 15:46:34 UTC 2023


On Sat, 17 Jun 2023 00:41:32 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits:
>> 
>>  - Merge branch 'openjdk:master' into rematerialization-of-merges
>>  - Rome minor refactorings.
>>  - Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>    Catching up with master.
>>  - Address PR review 6: debug format output & some refactoring.
>>  - Catching up with master branch.
>>    
>>    Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Address PR review 6: refactoring around rematerialization & improve test cases.
>>  - Address PR review 5: refactor on rematerialization & add tests.
>>  - Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - Address part of PR review 4 & fix a bug setting only_candidate
>>  - Catching up with master
>>    
>>    Merge remote-tracking branch 'origin/master' into rematerialization-of-merges
>>  - ... and 9 more: https://git.openjdk.org/jdk/compare/57b82512...939dcffe
>
> Testing results (both functional and performance) are good.
> 
> In addition, I tested with a guarantee that no `retry_no_reduce_allocation_merges()` failures are observed and there were no failures observed.
> 
> Once you address my latest comments I'll mark the PR as reviewed.

Thank you once more for the comments @iwanowww . I’ll address them asap. 

Can I ask what requirements are there for a product flag?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12897#issuecomment-1597395112


More information about the hotspot-dev mailing list