RFR: 8310332: Fix -Wconversion warnings in MethodData
Coleen Phillimore
coleenp at openjdk.org
Tue Jun 20 13:23:08 UTC 2023
On Tue, 20 Jun 2023 12:29:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Please review this change to narrow parameter and return types to avoid implicit casts, add casts where obvious, add checked_cast<> where not obvious and changed the size of a couple parameters to not cast to the smaller size.
> I didn't change TypeProfileWidth and BciProfileWidth because jvmci and SA care about the sizes.
> Tested tier1 all Oracle supported platforms, and tier1-4 linux + windows x64.
Thank you Andrew. I tried to only use narrowing casts where they're obviously correct because checked_cast<> comes with its own set of problems (and my builds seem to be getting slower). Thanks for reviewing.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14557#issuecomment-1598764398
More information about the hotspot-dev
mailing list