RFR: 8310110: Shenandoah: Trace page sizes [v5]

Thomas Stuefe stuefe at openjdk.org
Tue Jun 20 15:21:45 UTC 2023


> `-Xlog:pagesize` now produced this printout
> 
> 
> [0.006s][info][pagesize] Heap: req_size=5G base=0x00000006c0000000 page_size=1G alignment=1G size=5G
> [0.006s][info][pagesize] Mark Bitmap: req_size=160M base=0x00007fc4c0000000 page_size=1G alignment=1G size=1G
> [0.011s][info][pagesize] Aux Bitmap: req_size=160M base=0x00007fc4c0000000 page_size=1G alignment=1G size=1G
> [0.011s][info][pagesize] Region Storage: req_size=320K base=0x00007fc3c0000000 page_size=1G alignment=1G size=1G
> [0.011s][info][pagesize] Collection Set: req_size=16K base=0x0000000000010000 page_size=4K alignment=4K size=16K
> 
> 
> Note that this printout is from a machine with 1G pages and -XX:+UseLargePages; it nicely demonstrates how much memory we waste in that case on support structures; https://bugs.openjdk.org/browse/JDK-8310111 tracks that.
> 
> Also note that I reuse `os::trace_page_sizes_for_requested_size` here, which I think can be improved and made clearer (alignment is actually requested pagesize). This is tracked separately in https://github.com/openjdk/jdk/pull/14484 .

Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - remove test changes from patch
 - Merge branch 'master' into JDK-8310110-Trace-page-sizes
 - remove Shenandoah from TestTracePageSizes
 - disable Shenandoah THP trace test for now
 - reformat
 - enable runtime/os/TestTracePageSizes.java for shenandoah
 - feedback aleksey
 - Merge branch 'master' into JDK-8310110-Trace-page-sizes
 - JDK-8310110-Trace-page-sizes

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14486/files
  - new: https://git.openjdk.org/jdk/pull/14486/files/07e113f1..3a84de1c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14486&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14486&range=03-04

  Stats: 4151 lines in 208 files changed: 2401 ins; 1152 del; 598 mod
  Patch: https://git.openjdk.org/jdk/pull/14486.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14486/head:pull/14486

PR: https://git.openjdk.org/jdk/pull/14486


More information about the hotspot-dev mailing list