RFR: 8308771: Redundant header file in interp_masm_<archs>.hpp

[David Holmes]

On Thu, 25 May 2023 03:06:16 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> I've restored the changes for x86 as it seemed to break the build, not sure why.

That tells me something is not what it seems here.

There are different styles/approaches for dealing with includes in header files. One approach is to explicitly include every header file that is needed by the current header file - this makes the header file less brittle. The approach you seem to be advocating here is that as long as the dependencies of the header file are included before the header itself, then that is fine. I'm not sure which style dominates in hotspot (the style guide doesn't seem to cover it). But as this seems a personal style preference I'm not really seeing a reason to make the change.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14137#issuecomment-1600278302